BUG: Avoid casting to double type unnecessarily when setting values i… #23462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @icexelloss! Thanks for submitting the PR.
|
icexelloss
force-pushed
the
timedelta-casting-bug
branch
2 times, most recently
from
b43b803 to
ca6bbd3
Compare
Codecov Report
@@ Coverage Diff @@
## master #23462 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 161 161
Lines 51197 51197
=======================================
Hits 47220 47220
Misses 3977 3977
Continue to review full report at Codecov.
|
jreback
added
Bug
Indexing
jreback
requested changes
Nov 3, 2018
| @@ -80,3 +80,16 @@ def test_numpy_timedelta_scalar_indexing(self, start, stop, | |||
| result = s.loc[slice(start, stop)] | |||
| expected = s.iloc[expected_slice] | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_set_dataframe_column_by_index(self): | |||
|
|
|||
There was a problem hiding this comment.
can you add this PR number here as a comment
| @@ -80,3 +80,16 @@ def test_numpy_timedelta_scalar_indexing(self, start, stop, | |||
| result = s.loc[slice(start, stop)] | |||
| expected = s.iloc[expected_slice] | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_set_dataframe_column_by_index(self): | |||
There was a problem hiding this comment.
can rename to
test_roundtrip_thru_setitem
|
|
||
| df = pd.DataFrame({'dt': pd.Series([dt1, dt2])}) | ||
| s = pd.Series([dt1]) | ||
| value_before = df['dt'].iloc[1].value |
| s = pd.Series([dt1]) | ||
| value_before = df['dt'].iloc[1].value | ||
| df.loc[[True, False]] = s | ||
| value_after = df['dt'].iloc[1].value |
| value_before = df['dt'].iloc[1].value | ||
| df.loc[[True, False]] = s | ||
| value_after = df['dt'].iloc[1].value | ||
|
|
There was a problem hiding this comment.
can you also test
tm.assert_frame_equal(df, df_copy)
(and copy df on line 89)
icexelloss
force-pushed
the
timedelta-casting-bug
branch
from
ca6bbd3 to
62ab354
Compare
gfyoung
added
Numeric Operations
jreback
approved these changes
Nov 5, 2018
|
lgtm. ping on green. |
|
thanks @icexelloss |
|
Thanks @jreback ! |
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n time delta column
git diff upstream/master -u -- "*.py" | flake8 --diffWhen setting a timedelta column in a dataframe using
pd.Seriesor array as index, there is some rounding error because the underlying TimeDeltaBlock is casted to double and back to int. This patch fixes the issue.